Drop workaround for license-parsing regression in Meson 1.10.0#428
Draft
bgilbert wants to merge 2 commits intoopenslide:mainfrom
Draft
Drop workaround for license-parsing regression in Meson 1.10.0#428bgilbert wants to merge 2 commits intoopenslide:mainfrom
bgilbert wants to merge 2 commits intoopenslide:mainfrom
Conversation
We're about to drop the bug workaround, so require older API versions that don't have 1.10.0. This partially reverts commit 5d032f0. Signed-off-by: Benjamin Gilbert <bgilbert@cs.cmu.edu>
…0.0" Meson 1.10.1 fixes the bug. This reverts commit d91ccc3. Signed-off-by: Benjamin Gilbert <bgilbert@cs.cmu.edu>
Member
DCO signed off ✔️All commits have been signed off. You have certified to the terms of the Developer Certificate of Origin, version 1.1. In particular, you certify that this contribution has not been developed using information obtained under a non-disclosure agreement or other license terms that forbid you from contributing it under the GNU Lesser General Public License, version 2.1. |
Member
Author
|
The regression is fixed on x86_64 but not on aarch64 (mesonbuild/meson#15544); marking draft. |
Member
Author
|
Will need a revert of #429 before this lands. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Reject builder containers that declare the API version we added for Meson 1.10.0.